Skip to content

better exclusion of AUTHORIZATION headers #67

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

better exclusion of AUTHORIZATION headers #67

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 5 additions & 11 deletions src/oatpp-swagger/Generator.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -253,6 +253,10 @@ void Generator::addParamsToParametersList(const PathItemParameters& paramsList,
{

for(auto& paramName : params.getOrder()) {
if(paramName == oatpp::web::protocol::http::Header::AUTHORIZATION) {
continue;
}

auto param = params[paramName];
auto parameter = oas3::PathItemParameter::createShared();
parameter->in = inType;
Expand Down Expand Up @@ -416,17 +420,7 @@ void Generator::generatePathItemData(const std::shared_ptr<Endpoint>& endpoint,

operation->parameters = {};

Endpoint::Info::Params filteredHeaders;
if(!info->headers.getOrder().empty()) {
for (const auto &header : info->headers.getOrder()) {
// We don't want the Authorization header listed as Parameter. This should be done in ENDPOINT_INFO() { info->addSecurityRequirement( /* SecurityScheme-Name */ ); }
if (header != oatpp::web::protocol::http::Header::AUTHORIZATION) {
filteredHeaders[header] = info->headers[header];
}
}
}

addParamsToParametersList(operation->parameters, filteredHeaders, "header", usedTypes);
addParamsToParametersList(operation->parameters, info->headers, "header", usedTypes);
addParamsToParametersList(operation->parameters, info->pathParams, "path", usedTypes);
addParamsToParametersList(operation->parameters, info->queryParams, "query", usedTypes);

Expand Down