Skip to content

fix(#1146): correct the hasOwnProperty check in tinted-console.enable() #1151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ImilB wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(#1146): correct the hasOwnProperty check in tinted-console.enable() #1151

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 5 additions & 8 deletions src/tinted-console.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,16 +39,13 @@ for (const level in levels) {
}

/**
* Enable this particular logging level.
* Enable this particular logging level (and only this one).
* @param {String} level - The level to enable
* @throws {Error} If the level name is not one of the known levels
*/
module.exports.enable = function enable(level) {
for (const key in levels) {
if (levels.hasOwnProperty(level)) {
levels[key] = true;
if (key === level) {
break;
}
}
if (!levels.hasOwnProperty(level)) {

@Thayorns Thayorns Aug 3, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line is indented three spaces while the closing brace under it sits at two. eslint.config.js sets 'indent': ['error', 2, {"SwitchCase": 1}], so npx eslint reports this file as an error and the build stops before anything else in the change is looked at.

throw new Error(`Unknown log level: "${level}"`);
}
levels[level] = true;
};
Loading