Skip to content

fix: use kSecAccessControlDevicePasscode as a fallback on IOS #760

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

fix: use kSecAccessControlDevicePasscode as a fallback on IOS #760

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d25fefa
fix: use kSecAccessControlDevicePasscode as a fallback on IOS
DorianMazur Jun 15, 2025
7b9e2ed
Merge branch 'master' into fix/ios-fallback-when-no-biometrics
DorianMazur Jun 15, 2025
4751ea2
Update RNKeychainManager.m
DorianMazur Jun 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
61 changes: 41 additions & 20 deletions ios/RNKeychainManager/RNKeychainManager.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,30 +183,51 @@ LAPolicy authPolicy(NSDictionary *options)

SecAccessControlCreateFlags accessControlValue(NSDictionary *options)
{
SecAccessControlCreateFlags flags = 0;
if (options && options[kAccessControlType] && [options[kAccessControlType] isKindOfClass:[NSString class]]) {
if ([options[kAccessControlType] isEqualToString: kAccessControlUserPresence]) {
return kSecAccessControlUserPresence;
NSString *type = options[kAccessControlType];

if ([type isEqualToString:kAccessControlUserPresence]) {
flags = kSecAccessControlUserPresence;
} else if ([type isEqualToString:kAccessControlBiometryAny]) {
flags = kSecAccessControlTouchIDAny;
} else if ([type isEqualToString:kAccessControlBiometryCurrentSet]) {
flags = kSecAccessControlTouchIDCurrentSet;
} else if ([type isEqualToString:kAccessControlDevicePasscode]) {
flags = kSecAccessControlDevicePasscode;
} else if ([type isEqualToString:kAccessControlBiometryAnyOrDevicePasscode]) {
flags = kSecAccessControlTouchIDAny |
kSecAccessControlOr |
kSecAccessControlDevicePasscode;
} else if ([type isEqualToString:kAccessControlBiometryCurrentSetOrDevicePasscode]) {
flags = kSecAccessControlTouchIDCurrentSet |
kSecAccessControlOr |
kSecAccessControlDevicePasscode;
} else if ([type isEqualToString:kAccessControlApplicationPassword]) {
flags = kSecAccessControlApplicationPassword;
}
else if ([options[kAccessControlType] isEqualToString: kAccessControlBiometryAny]) {
return kSecAccessControlTouchIDAny;
}
else if ([options[kAccessControlType] isEqualToString: kAccessControlBiometryCurrentSet]) {
return kSecAccessControlTouchIDCurrentSet;
}
else if ([options[kAccessControlType] isEqualToString: kAccessControlDevicePasscode]) {
return kSecAccessControlDevicePasscode;
}
else if ([options[kAccessControlType] isEqualToString: kAccessControlBiometryAnyOrDevicePasscode]) {
return kSecAccessControlTouchIDAny|kSecAccessControlOr|kSecAccessControlDevicePasscode;
}
else if ([options[kAccessControlType] isEqualToString: kAccessControlBiometryCurrentSetOrDevicePasscode]) {
return kSecAccessControlTouchIDCurrentSet|kSecAccessControlOr|kSecAccessControlDevicePasscode;
}
else if ([options[kAccessControlType] isEqualToString: kAccessControlApplicationPassword]) {
return kSecAccessControlApplicationPassword;
}
#if TARGET_OS_IOS || TARGET_OS_VISION
BOOL requestedBiometric =
(flags & kSecAccessControlTouchIDAny) ||
(flags & kSecAccessControlTouchIDCurrentSet);

BOOL requestedPasscode =
(flags & kSecAccessControlDevicePasscode);

if (requestedBiometric && requestedPasscode) {
NSError *aerr = nil;
BOOL canAuthenticate = [[LAContext new] canEvaluatePolicy:LAPolicyDeviceOwnerAuthenticationWithBiometrics error:&aerr];

if (!canAuthenticate)
{
// No usable biometrics – use the safest subset.
flags = kSecAccessControlDevicePasscode;
}
}
return 0;
#endif

return flags;
}

- (void)insertKeychainEntry:(NSDictionary *)attributes
Expand Down
Loading