Propagate original error in RuntimeError.cause (#1)#324
Open
innermatrix wants to merge 2 commits intoobservablehq:mainfrom
Open
Propagate original error in RuntimeError.cause (#1)#324innermatrix wants to merge 2 commits intoobservablehq:mainfrom
innermatrix wants to merge 2 commits intoobservablehq:mainfrom
Conversation
mbostock
reviewed
Dec 1, 2021
Co-authored-by: Mike Bostock <mbostock@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, if a variable's value function throws a custom subclass of
Error, that custom subclass is lost when the error is converted toRuntimeError, and is subsequently unavailable in the inspector. This PR puts the original error inRuntimeError.cause, thereby making it available to custom inspectors. Behavior of the default inspector is unchanged.