-
-
Notifications
You must be signed in to change notification settings - Fork 77
Configuration for additional URL patterns #328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
MaralWa
wants to merge
6
commits into
obsidian-nvim:main
Choose a base branch
from
MaralWa:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
995901f
Configuration for additiional URL patterns that can be opened by the …
e81c1aa
Merge branch 'obsidian-nvim:main' into main
MaralWa 309fa33
documentation and tests for ulr_patterns
c198d7b
fix spelling in documentation for url_patterns
3c6d0f0
fixes for failed pull request
17f76a4
fix wrong example configuration in documentation
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,55 @@ | ||
local M = require "obsidian.util" | ||
local Path = require "obsidian.path" | ||
local new_set, eq = MiniTest.new_set, MiniTest.expect.equality | ||
|
||
local T = new_set { | ||
hooks = { | ||
pre_case = function() | ||
local dir = Path.temp { suffix = "-obsidian" } | ||
dir:mkdir { parents = true } | ||
require("obsidian").setup { | ||
url_patterns = { | ||
{ | ||
name = "URL-UUID", | ||
pattern = "uuid://[0-9a-fA-F]+%-[0-9a-fA-F]+%-[0-9a-fA-F]+%-[0-9a-fA-F]+%-[0-9a-fA-F]+", | ||
}, | ||
{ | ||
name = "App", | ||
pattern = "app:///data/[a-zA-Z]+", | ||
}, | ||
}, | ||
workspaces = { { | ||
path = tostring(dir), | ||
} }, | ||
} | ||
end, | ||
}, | ||
} | ||
|
||
T["url_patterns"] = new_set() | ||
|
||
T["url_patterns"]["should identify basic URLs"] = function() | ||
eq(true, M.is_url "https://example.com") | ||
end | ||
|
||
T["url_patterns"]["should identify semantic scholar API URLS"] = function() | ||
eq(true, M.is_url "https://api.semanticscholar.org/CorpusID:235829052") | ||
end | ||
|
||
T["url_patterns"]["should identify 'mailto' URLS"] = function() | ||
eq(true, M.is_url "mailto:[email protected]") | ||
end | ||
|
||
T["url_patterns"]["should identify URL-UUID"] = function() | ||
eq(true, M.is_url "uuid://abcdef-1234-5678-90af-abcdef") | ||
end | ||
|
||
T["url_patterns"]["should identify App-URL"] = function() | ||
eq(true, M.is_url "app:///data/testData") | ||
end | ||
|
||
T["url_patterns"]["should not identify unknown URL pattern"] = function() | ||
eq(false, M.is_url "unknown://some.unknown.url") | ||
end | ||
|
||
return T |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -36,6 +36,10 @@ T["is_url"]["should identify 'mailto' URLS"] = function() | |
eq(true, M.is_url "mailto:[email protected]") | ||
end | ||
|
||
T["is_url"]["uncofigured URLs should not be identified"] = function() | ||
eq(false, M.is_url "some_protocoll://data") | ||
end | ||
|
||
T["is_checkbox"] = new_set() | ||
|
||
T["is_checkbox"]["should return true for valid checkbox list items"] = function() | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
follow_url_func