Skip to content

utils: Add multi video and frame rate divisor support to GetOutputDuration #1274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

utils: Add multi video and frame rate divisor support to GetOutputDuration #1274

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion src/utils/Obs_NumberHelper.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,17 @@ uint64_t Utils::Obs::NumberHelper::GetOutputDuration(obs_output_t *output)
uint64_t frameTimeNs = video_output_get_frame_time(video);
int totalFrames = obs_output_get_total_frames(output);

return util_mul_div64(totalFrames, frameTimeNs, 1000000ULL);
// calculating the divisor is a hack to support multiple video encoders, someone please improve this in the future
uint64_t divisor = 0ULL;
for (size_t i = 0; i < MAX_OUTPUT_VIDEO_ENCODERS; i++) {
obs_encoder_t *encoder = obs_output_get_video_encoder2(output, i);
if (!encoder)
continue;
uint32_t encoder_divisor = obs_encoder_get_frame_rate_divisor(encoder);
divisor += encoder_divisor <= 1 ? 1000000ULL : 1000000ULL / encoder_divisor;
}

return util_mul_div64(totalFrames, frameTimeNs, divisor ? divisor : 1000000ULL);
}

size_t Utils::Obs::NumberHelper::GetSceneCount()
Expand Down