Skip to content

Add a test to ensure the illustrate the behavior of type-enclosing command showed in issue #1949 #2004

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+11 −0
Open

Add a test to ensure the illustrate the behavior of type-enclosing command showed in issue #1949 #2004

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions tests/test-dirs/type-enclosing/issue1949.t
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
$ cat >main.ml <<EOF
> let foo a b = b
> EOF

$ $MERLIN single type-enclosing -position 1:6 -filename main.ml <main.ml | jq .value.[0].type
"'a -> 'b -> 'b"

Inconsistent type variables are returned by `type-enclosing`. In term of user experience, the type of `b` it should be `'b`.
See https://github.com/ocaml/merlin/issues/1949.
$ $MERLIN single type-enclosing -position 1:14 -filename main.ml <main.ml | jq .value.[0].type
"'a"
Loading