Skip to content

Reduced duplicated names in contributor list #1546

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Reduced duplicated names in contributor list #1546

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1fdda7a
edited command to get contributor names
lindaokorie27 Apr 20, 2021
3274871
refactored contributor list to display full names
lindaokorie27 Apr 21, 2021
851ac1f
further sorted extracted names
lindaokorie27 Apr 22, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion site/contributors.fr.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ Contributeurs

Les contributeurs à ce site :
<ul id="contributors_list">
((! cmd git log --format="%aN" | sort | uniq | awk '{print "<li>"$1,$2,$3"</li>"}' !))
((! cmd git log --format="%aE %aN" | sort | uniq | awk '{print "<li>"$2,"</li>"}' !))
</ul>

Cette liste est obtenue depuis [le log GIT](https://github.com/ocaml/ocaml.org/commits/master), pensez à vérifier que votre
Expand Down
2 changes: 1 addition & 1 deletion site/contributors.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ The contributors to this site, extracted from the
[Git log](https://github.com/ocaml/ocaml.org/commits/master), are:

<ul id="contributors_list">
((! cmd git log --format="%aN" | sort | uniq | awk '{print "<li>"$1,$2,$3"</li>"}' !))
((! cmd git log --format="%aE %aN" | sort | uniq | awk '{print "<li>"$2,"</li>"}' !))
Copy link

@gs0510 gs0510 Apr 21, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This results in printing only the first name of folks which isn't what we want. You want to list only the contributors using their email as a key for finding unique contributors.

Copy link
Author

@lindaokorie27 lindaokorie27 Apr 21, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh sorry. Let me try again.

Copy link
Author

@lindaokorie27 lindaokorie27 Apr 21, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gs0510 I have worked on it now. It displays contributor's full names. It removes names attached to the same email address. There are a lot of contributors though that have multiple email addresses.

Copy link

@gs0510 gs0510 Apr 22, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@LindieK you can look into how to find only the uniq names in the list so awk can print only them. :)

Copy link
Author

@lindaokorie27 lindaokorie27 Apr 22, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for idea. I'll look into it right away

Copy link
Author

@lindaokorie27 lindaokorie27 Apr 22, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I sorted it further after the awk statement. The only thing left causing duplications is that the email and name documented on some commits are the person's github username (different from the full name used in other commit messages) and the auto-generated email from github that has the @users.noreply.gtihub.com extension.

</ul>


Expand Down