Fix bug in drop columns in normalize_coops_stations #178
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue with how columns are dropped in
normalize_coops_stations
.As it was,
df.drop
was called with columns that might not exist, which would raise an exception. There was already logic in place to check if these columns existed, so I moved thedf.drop
to be within thoseif
statements.I ran the test suite (
make test
) and all the COOPS tests passed (overall, 166 passed, 30 warnings).