This repository was archived by the owner on Aug 30, 2024. It is now read-only.
Support storing cert-info in S3 #16
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey Mike.... thanks for contributing! I'm planning to go back through the codebase in the next couple of weeks and I'll definitely implement a suggestion like this (although final details might differ slightly). Thanks again! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some use cases, it may be inconvenient to redeploy the lambda every time the
certificate-infochanges. This allows the option of storing the certificate info in a JSON file in thes3-account-bucket, while still supporting storing the info directly in the config for cases where that is simpler.