Skip to content

Conversation

@wolfy1339
Copy link
Member

Fixes octokit/octokit.js#2904


Before the change?

After the change?

  • Endpoints that allow uploading binary data have their request body type to different types used to represent files, and are accpeted in fech

Pull request checklist

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

  • Yes
  • No

@wolfy1339 wolfy1339 added the Type: Bug Something isn't working as documented label Nov 1, 2025
@octokit
Copy link
Contributor

octokit bot commented Nov 1, 2025

👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labeled with Status: Up for grabs. You & others like you are the reason all of this works! So thank you & happy coding! 🚀

Copy link

@Uzlopak Uzlopak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wolfy1339 wolfy1339 moved this from 🆕 Triage to 🔖 Ready in 🧰 Octokit Active Nov 2, 2025
@wolfy1339 wolfy1339 moved this from 🔖 Ready to 🆕 Triage in 🧰 Octokit Active Nov 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Type: Bug Something isn't working as documented

Projects

Status: 🆕 Triage

Development

Successfully merging this pull request may close these issues.

[BUG]: uploadReleaseAsset does not accept data as buffer

4 participants