Skip to content

Conversation

@wolfy1339
Copy link
Member

@wolfy1339 wolfy1339 commented Feb 24, 2025

Add back types import that was lost in the transition to ESM

Part of #1055


Before the change?

  • Previously any file was available to import when the package was CJS, when we switched to ESM you couldn't use that import path anymore.

After the change?

  • Adds a /type entrypoint to allow importing some "internal" types

Pull request checklist

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

  • Yes
  • No

@wolfy1339 wolfy1339 added the Type: Bug Something isn't working as documented, or is being fixed label Feb 24, 2025
@github-actions
Copy link
Contributor

👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labeled with Status: Up for grabs. You & others like you are the reason all of this works! So thank you & happy coding! 🚀

Add back event handler import that was lost in the transition to ESM

remove event-handler entrypoint
@wolfy1339 wolfy1339 merged commit 4a2d81a into main Feb 24, 2025
7 checks passed
@wolfy1339 wolfy1339 deleted the add-esm-entrypoints branch February 24, 2025 19:42
@github-actions
Copy link
Contributor

🎉 This PR is included in version 13.7.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

released Type: Bug Something isn't working as documented, or is being fixed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants