Skip to content

Conversation

@Renegade334
Copy link
Contributor

Resolves #1118.


Before the change?

... (request: Request) => Promise<import("undici-types").Response>;

After the change?

... (request: Request) => Promise<Response>;

Pull request checklist

  • Tests for the changes have been added (for bug fixes / features)
    • The original featureset did not add tests.
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

  • Yes
  • No

@github-actions
Copy link
Contributor

👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labeled with Status: Up for grabs. You & others like you are the reason all of this works! So thank you & happy coding! 🚀

@wolfy1339 wolfy1339 added Type: Bug Something isn't working as documented, or is being fixed typescript Relevant to TypeScript users only labels Feb 24, 2025
@wolfy1339 wolfy1339 enabled auto-merge (squash) February 24, 2025 23:39
@jakebailey
Copy link

Thanks for sending this; this is causing errors on DefinitelyTyped.

@wolfy1339 wolfy1339 merged commit 7570dc0 into octokit:main Feb 24, 2025
8 checks passed
@github-actions
Copy link
Contributor

🎉 This PR is included in version 13.7.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

released Type: Bug Something isn't working as documented, or is being fixed typescript Relevant to TypeScript users only

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG]: inferred web middleware type depends on import("undici-types")

3 participants