Skip to content

Conversation

wolfy1339
Copy link
Member

@wolfy1339 wolfy1339 commented May 12, 2025

BREAKING CHANGE: Drop support for NodeJS v18

@wolfy1339 wolfy1339 added Type: Breaking change Used to note any change that requires a major version bump Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR labels May 12, 2025
Copy link
Contributor

👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labeled with Status: Up for grabs. You & others like you are the reason all of this works! So thank you & happy coding! 🚀

@wolfy1339 wolfy1339 changed the title ci: stop testing against NodeJS v10, v12, v14, v16, v18 ci: stop testing against NodeJS v18 May 12, 2025
@wolfy1339 wolfy1339 force-pushed the remove-eol-node-versions branch 4 times, most recently from fb62a3e to 83e2b8d Compare May 12, 2025 20:17
@Uzlopak
Copy link
Contributor

Uzlopak commented May 12, 2025

why 20.17?

@wolfy1339
Copy link
Member Author

It's just an error.
If anything, it should be 20.19 and not 20.17, for require(esm)

@wolfy1339 wolfy1339 force-pushed the remove-eol-node-versions branch from 83e2b8d to 00a9b52 Compare May 12, 2025 22:10
oscard0m
oscard0m previously approved these changes May 20, 2025
@wolfy1339 wolfy1339 enabled auto-merge (squash) May 20, 2025 11:31
@wolfy1339 wolfy1339 requested a review from oscard0m May 20, 2025 11:31
@wolfy1339 wolfy1339 changed the base branch from main to renovate/major-octokit-monorepo May 20, 2025 15:54
@wolfy1339 wolfy1339 disabled auto-merge May 20, 2025 15:54
@wolfy1339 wolfy1339 merged commit a00c18f into renovate/major-octokit-monorepo May 20, 2025
11 checks passed
@github-project-automation github-project-automation bot moved this from 🆕 Triage to ✅ Done in 🧰 Octokit Active May 20, 2025
@wolfy1339 wolfy1339 deleted the remove-eol-node-versions branch May 20, 2025 15:55
wolfy1339 added a commit that referenced this pull request May 20, 2025
* ci: stop testing against NodeJS v18 (#1149)

BREAKING CHANGE: Drop support for NodeJS v18
---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: wolfy1339 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Type: Breaking change Used to note any change that requires a major version bump Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

3 participants