[IMP] account: add sent status column and filters on invoice list - #4874
Open
jugurtha-gaci wants to merge 2 commits into
Conversation
|
This PR targets the un-managed branch odoo-dev/odoo:18.0-rd-accounting-onboarding-malb, it needs to be retargeted before it can be merged. |
malb-odoo
reviewed
Nov 7, 2025
malb-odoo
left a comment
malb-odoo
left a comment
There was a problem hiding this comment.
Still the commits problems + some impss
| @@ -340,6 +340,12 @@ def _sequence_year_range_monthly_regex(self): | |||
| copy=False, | |||
| domain=[('display_type', 'in', ('product', 'line_section', 'line_note'))], | |||
| ) | |||
| invoice_sent_status = fields.Selection( | |||
| selection=[('sent', "Sent"), ('not_sent', "Not sent")], | |||
There was a problem hiding this comment.
Suggested change
| selection=[('sent', "Sent"), ('not_sent', "Not sent")], | |
| selection=[ | |
| ('sent', "Sent"), | |
| ('not_sent', "Not sent") | |
| ], |
| @@ -340,6 +340,12 @@ def _sequence_year_range_monthly_regex(self): | |||
| copy=False, | |||
| domain=[('display_type', 'in', ('product', 'line_section', 'line_note'))], | |||
| ) | |||
| invoice_sent_status = fields.Selection( | |||
| selection=[('sent', "Sent"), ('not_sent', "Not sent")], | |||
| compute='_compute_is_sent', | |||
There was a problem hiding this comment.
Convention for the compute it should generally be like this, you take the name of the field as the name of compute (except if the compute is present on multiple field)
Suggested change
| compute='_compute_is_sent', | |
| compute='_compute_invoice_sent_status', |
Comment on lines
+1599
to
+1606
| <filter name="invoice_sent_status" | ||
| string="Sent invoices" | ||
| domain="[('invoice_sent_status', '=', 'sent')]" | ||
| /> | ||
| <filter name="invoice_sent_status" | ||
| string="Not sent invoices" | ||
| domain="[('invoice_sent_status', '=', 'not_sent')]" | ||
| /> |
There was a problem hiding this comment.
Just look at the one below, the not_sent is already present so let's do the same but for sent, no need to add those extra 😄
jugurtha-gaci
force-pushed
the
18.0-rd-accounting-onboarding-add-sent-column-to-invoices-list-jugac
branch
from
November 10, 2025 12:06
64cc296 to
3cfd6a9
Compare
jugurtha-gaci
changed the title
jugurtha-gaci
force-pushed
the
18.0-rd-accounting-onboarding-add-sent-column-to-invoices-list-jugac
branch
from
November 17, 2025 08:42
3cfd6a9 to
3ecd648
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To improve traceability for users, it is now necessary to easily see which invoices have been sent, especially with the rise of electronic invoicing.
This PR adds the 'sent' status as an optional column in the invoice list view. It also introduces two new search filters: 'Sent Invoices' and 'Not Sent Invoices' to quickly track documents that need to be dispatched.
task-5231314
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr