MALER Onboarding #995

MatteoLeroy · 2025-10-20T11:42:01Z

No description provided.

robodoo · 2025-10-20T11:42:04Z

alan-odoo

Thanks for your work. Except for the missing blank lines, the pep8 is respected and that's good 😃.

alan-odoo · 2025-10-20T14:15:01Z

estate/models/__init__.py

@@ -0,0 +1 @@
+from . import estate_property


A blank line is missing at the end of your file. You have to put it at the end of all of your files 😃.

alan-odoo · 2025-10-20T14:16:21Z

estate/models/estate_property.py

+    garden_orientation = fields.Selection(
+        string='Orientation',
+        selection=[('north','North'), ('east','East'), ('south','South'), ('west','West')],
+    )


The blank line is also missing.

alan-odoo · 2025-10-20T14:18:22Z

estate/security/ir.model.access.csv

@@ -0,0 +1,2 @@
+id,name,model_id/id,group_id/id,perm_read,perm_write,perm_create,perm_unlink
+access_estate_property,access_estate_property,model_estate_property,base.group_user,1,1,1,1


The blank line is also missing here too 😃.

alan-odoo · 2025-10-20T14:18:48Z

estate/__init__.py

@@ -0,0 +1 @@
+from . import models


alan-odoo · 2025-10-20T14:19:25Z

estate/__manifest__.py

+    'data': [
+        'security/ir.model.access.csv',
+    ],
+}


Here too 😃

alan-odoo · 2025-10-20T14:32:02Z

estate/models/estate_property.py

@@ -0,0 +1,22 @@
+from odoo import models, fields
+


A blank line is missing here. You should have two blank lines above a class. It is a python convention coming from the pip8.

alan-odoo

Hi @MatteoLeroy 👋

I did a new review of your code. Here are comments about code optimization and python conventions.

Thanks for you work 😃.

alan-odoo · 2025-10-28T12:13:47Z

estate/models/__init__.py

+from . import estate_property
+from . import estate_property_type
+from . import estate_property_tag
+from . import estate_property_offer
+from . import inherited_user


Should be sorted alphabetically 😃.

alan-odoo · 2025-10-28T12:40:33Z

estate/models/estate_property.py

+from odoo import api, models, fields
+from odoo.exceptions import UserError
+import datetime
+from dateutil.relativedelta import relativedelta
+from odoo.tools.float_utils import float_compare


Same here.

You must also place built-in imports before external imports and external imports before internal imports. A built-in import is when you import code that comes with Python by default (such as datetime). An external import occurs when you import code from outside your project (such as dateutil). And an internal import occurs when you import a code that is present in your project, but in another file.

Suggested change

from odoo import api, models, fields

from odoo.exceptions import UserError

import datetime

from dateutil.relativedelta import relativedelta

from odoo.tools.float_utils import float_compare

import datetime

from dateutil.relativedelta import relativedelta

from odoo import api, fields, models

from odoo.exceptions import UserError

from odoo.tools.float_utils import float_compare

alan-odoo · 2025-10-28T13:36:38Z

estate/models/estate_property.py

+        for record in self:
+            if record.state == 'sold':
+                raise UserError('A sold property cannot be cancelled')
+            else:
+                record.state = 'cancelled'
+        return True


Here, your action is used on a form. That means that you are updating only one record. So you do not need to iterate self and you can add a self.ensure_one() to make sure that your self contains only one record, if it is not the case it triggered an error, and so it protects the db. You can apply that to all method called by a button in a form.

Suggested change

for record in self:

if record.state == 'sold':

raise UserError('A sold property cannot be cancelled')

else:

record.state = 'cancelled'

return True

self.ensure_one()

if self.state == 'sold':

raise UserError('A sold property cannot be cancelled')

record.state = 'cancelled'

return True

alan-odoo · 2025-10-28T13:54:23Z

estate/models/estate_property.py

+    @api.ondelete(at_uninstall=False)
+    def unlink_property(self):
+        for record in self:
+            if record.state != 'new' and record.state != 'canceled':


Do not hesitate to use the in operator when you accept several values for a variable.

Suggested change

if record.state != 'new' and record.state != 'canceled':

if record.state in ['new', 'canceled']:

alan-odoo · 2025-10-28T13:55:31Z

estate/models/estate_property_offer.py

@@ -0,0 +1,67 @@
+from odoo import api, models, fields


Should be sorted alphabetically.

Suggested change

from odoo import api, models, fields

from odoo import api, fields, models

alan-odoo · 2025-10-28T14:36:29Z

estate/views/estate_property_tag_views.xml

+            </list>
+        </field>
+    </record>
+</odoo>  


alan-odoo · 2025-10-28T14:36:46Z

estate/views/estate_property_type_views.xml

+            </list>
+        </field>
+    </record>
+</odoo> 


alan-odoo · 2025-10-28T14:37:03Z

estate/views/estate_property_views.xml

+            </kanban>
+        </field>
+    </record>
+</odoo>


alan-odoo · 2025-10-28T14:37:13Z

estate/views/inherited_user_views.xml

+            </notebook>
+        </field>
+    </record>
+</odoo>


alan-odoo · 2025-10-28T14:42:24Z

estate/models/inherited_user.py

+from odoo import fields, models
+
+
+class InheritedUser(models.Model):


The class and file should be named ResUser and res_user.py, respectively.

Mathilde411 changed the title ~~Add chapter 2~~ MALER Onboarding Oct 20, 2025

Mathilde411 requested a review from alan-odoo October 20, 2025 11:46

alan-odoo reviewed Oct 20, 2025

View reviewed changes

MatteoLeroy added 8 commits October 21, 2025 09:04

[ADD] chapter 2

4b94903

[ADD] estate: chapter 3

732cd24

[ADD] estate: author and license for chapter 2

abf17f4

[ADD] estate: chapter 4

755ef94

[ADD] estate: chapter 5

77b28ab

[FIX] estate errors runbot

f790264

[FIX] estate errors runbot 2

2ca3c10

[ADD] estate: default value to state

5108d34

MatteoLeroy force-pushed the 19.0-onboarding-maler branch from 147498a to 5108d34 Compare October 21, 2025 07:07

MatteoLeroy added 17 commits October 21, 2025 11:16

[ADD] chapter 6

950aa6a

[ADD] chapter 7

ebd00a8

[FIX] style check for chapter 7

eab30ee

[IMP] Chapter 8

bfdee5e

[FIX] style check for chapter 8

91f5f42

[IMP] Chapter 9

dd92e48

[FIX] style check for chapter 9

b327775

[FIX] style check for chapter 9

fe1800b

[IMP] Chapter 10

5124c90

[FIX] style check for chapter 10

31dfe65

[IMP] Chapter 11

155c968

[IMP] Chapter 12

a315476

[FIX] style check for Chapter 12

5b0378c

[IMP] chapter 13

83fd657

[FIX] style check for chapter 13

452451c

[IMP] Chapter 14

b808568

[IMP] unit tests

0c70ac5

[FIX] Style check for unit tests

2314ab9

alan-odoo reviewed Oct 28, 2025

View reviewed changes

		@@ -0,0 +1 @@
		from . import estate_property No newline at end of file

		@@ -0,0 +1,2 @@
		id,name,model_id/id,group_id/id,perm_read,perm_write,perm_create,perm_unlink
		access_estate_property,access_estate_property,model_estate_property,base.group_user,1,1,1,1 No newline at end of file

	if record.state != 'new' and record.state != 'canceled':
	if record.state in ['new', 'canceled']:

	from odoo import api, models, fields
	from odoo import api, fields, models

		from odoo import fields, models


		class InheritedUser(models.Model):

MALER Onboarding #995

Are you sure you want to change the base?

MALER Onboarding #995

Conversation

MatteoLeroy commented Oct 20, 2025

Uh oh!

robodoo commented Oct 20, 2025

Uh oh!

alan-odoo left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

alan-odoo left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants