Draft
Conversation
martinheidegger
force-pushed
the
feat/bip39
branch
2 times, most recently
from
e6eca8b to
5e72900
Compare
martinheidegger
force-pushed
the
feat/bip39
branch
from
5e72900 to
3db4ab6
Compare
martinheidegger
force-pushed
the
main
branch
2 times, most recently
from
75db7b0 to
fa06b6c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@kurisu-dotto-komu following our conversation I rechecked my math. No on roll-over of the generated password it will show the calculated entropy that the particular method uses and also I reworked the dictionary creation process for others to easier follow the effort. For a test I also added a bip-39 dictionary based fixed-length password generator and it needs to be far longer than the current one for an entropy exceeding the base32 variant.
