Handles Failed callbacks in process and stores failed statuses #506
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
joshuahannan
commented
Aug 7, 2025
joshuahannan
commented
- Marks processed callbacks that were not succeed as failed
- Stores failed statuses for callbacks in the historic callback field
Base automatically changed from
josh/refactor-config
to
feature/callback-scheduling
August 7, 2025 21:05
…o josh/failed-callbacks
devbugging
reviewed
Aug 8, 2025
devbugging
reviewed
Aug 11, 2025
contracts/FlowCallbackScheduler.cdc
Outdated
| @@ -244,7 +248,7 @@ access(all) contract FlowCallbackScheduler { | |||
| access(all) var refundMultiplier: UFix64 | |||
|
|
|||
| /// historic status limit is the maximum age of a historic canceled callback status we keep before getting pruned | |||
There was a problem hiding this comment.
maybe add in comment what is the unit (timestamp second)?
devbugging
reviewed
Aug 11, 2025
contracts/FlowCallbackScheduler.cdc
Outdated
| @@ -401,7 +426,7 @@ access(all) contract FlowCallbackScheduler { | |||
| Priority.Low: 2.0 | |||
| }, | |||
| refundMultiplier: 0.5, | |||
| historicStatusLimit: 30.0 * 24.0 * 60.0 * 60.0 // 30 days | |||
| historicStatusAgeLimit: 30.0 * 24.0 * 60.0 * 60.0 // 5 days | |||
There was a problem hiding this comment.
incorrect comment, let's keep it at 30 for now
devbugging
reviewed
Aug 11, 2025
contracts/FlowCallbackScheduler.cdc
Outdated
| if let historic = self.historicCallbacks[id] { | ||
| return historic.status | ||
| } else if id > self.earliestHistoricID { | ||
| return Status.Succeeded | ||
| } | ||
|
|
||
| return nil |
There was a problem hiding this comment.
NIT: I wonder if explicit Unknown status would be better.
There was a problem hiding this comment.
good suggestion. I'll add Unknown
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.