General callback scheduler improvements #508
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshuahannan
approved these changes
Aug 11, 2025
There was a problem hiding this comment.
I just left the same comments that I left on #507 so we can just work and merge from here
| access(all) contract FlowCallbackScheduler { | ||
|
|
||
| /// singleton instance used to store all callback data | ||
| /// and route all callback functionality | ||
| access(self) var sharedScheduler: Capability<auth(Cancel) &SharedScheduler> | ||
|
|
||
| access(all) let schedulerStoragePath: Path |
There was a problem hiding this comment.
Suggested change
| access(all) let schedulerStoragePath: Path | |
| access(all) let storagePath: Path |
| } | ||
|
|
||
| /// Get all timestamps that are in the past (less than or equal to current timestamp) | ||
| access(all) fun past(current: UFix64): [UFix64] { |
There was a problem hiding this comment.
Suggested change
| access(all) fun past(current: UFix64): [UFix64] { | |
| access(all) fun getTimestampsBefore(current: UFix64): [UFix64] { |
|
|
||
| /// Check if there are any timestamps that need processing | ||
| /// Returns true if processing is needed, false for early exit | ||
| access(all) fun check(current: UFix64): Bool { |
There was a problem hiding this comment.
Suggested change
| access(all) fun check(current: UFix64): Bool { | |
| access(all) fun checkIfTimestampsNeedProcessing(current: UFix64): Bool { |
joshuahannan
merged commit f96494a
into
onflow:feature/callback-scheduling
1 check failed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Restricting access to
processandexecuteto only service account, so the FVM can still execute them but others can't.Other minor improvements to comments and some code cleanup.