Skip to content

Conversation

illia-malachyn
Copy link
Contributor

@illia-malachyn illia-malachyn commented Sep 25, 2025

Access node has 2 main responsibilities:

  • serve data to end users
  • gather data from protocol

I created the api package to encapsulate all the logic related to serving data into 1 package. I think it's good to have a package for gathering data from the protocol, serving data to clients, and some common stuff.

P.s. I branched off illia-malachyn/7657-fork-aware-events-streaming-endpoints

This is the commit with all the changes 3d38688 (there's some commits afterwards with small fixes)

illia-malachyn and others added 30 commits August 26, 2025 12:55
- Extend openapi schema
- Refactor and extend types that handle openapi
types
…lia-malachyn/7657-fork-aware-events-streaming-endpoints
- move executor metadata to response types
- return executor metadata when needed
@illia-malachyn illia-malachyn requested a review from a team as a code owner September 25, 2025 09:41
@illia-malachyn illia-malachyn changed the base branch from master to feature/optimistic-sync September 25, 2025 09:41
@codecov-commenter
Copy link

codecov-commenter commented Sep 25, 2025

@illia-malachyn
Copy link
Contributor Author

illia-malachyn commented Sep 25, 2025

@peterargue does it make sense to do this change? Anyway, we do lots of refactoring currently.

@peterargue
Copy link
Contributor

@peterargue does it make sense to do this change? Anyway, we do lots of refactoring currently.

I agree with refactoring the APIs under a shared module. My preference would be to move it under /access/ instead of /engine/access, then have the engines, simply stand up the servers.

with that said, I would rather we take this on after merging the feature branch back into master. There are more API changes coming to support scheduled transactions, so if we can wait on some restructuring type work like this, it will make maintaining the feature branch easier.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants