-
Notifications
You must be signed in to change notification settings - Fork 197
[DataAvailability] introduce api package in access engine #7962
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: feature/optimistic-sync
Are you sure you want to change the base?
[DataAvailability] introduce api package in access engine #7962
Conversation
- Extend openapi schema - Refactor and extend types that handle openapi types
…lia-malachyn/7657-fork-aware-events-streaming-endpoints
- move executor metadata to response types - return executor metadata when needed
…aware-events-endpoint
…aware-events-endpoint
…lia-malachyn/7657-fork-aware-events-streaming-endpoints
…aware-events-endpoint
…lia-malachyn/7657-fork-aware-events-streaming-endpoints
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
@peterargue does it make sense to do this change? Anyway, we do lots of refactoring currently. |
I agree with refactoring the APIs under a shared module. My preference would be to move it under with that said, I would rather we take this on after merging the feature branch back into master. There are more API changes coming to support scheduled transactions, so if we can wait on some restructuring type work like this, it will make maintaining the feature branch easier. |
Access node has 2 main responsibilities:
I created the
api
package to encapsulate all the logic related to serving data into 1 package. I think it's good to have a package for gathering data from the protocol, serving data to clients, and some common stuff.P.s. I branched off illia-malachyn/7657-fork-aware-events-streaming-endpoints
This is the commit with all the changes 3d38688 (there's some commits afterwards with small fixes)