Collect EVM-related events during VM bridge bootstrapping

[m-Peter]

Work Towards: onflow/flow-evm-gateway#893

[codecov-commenter]

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

[Kay-Zee]

Great! Looks like the main difference is changing from run to runAndReturn, which also completely removes the run function, which had previously used invokeMetaTransaction and now just use runMetaTransaction, I believe the main thing here is that the events are returned, were there any other side effects to this change?

[m-Peter]

Great! Looks like the main difference is changing from run to runAndReturn, which also completely removes the run function, which had previously used invokeMetaTransaction and now just use runMetaTransaction, I believe the main thing here is that the events are returned, were there any other side effects to this change?

Hey @Kay-Zee , so invokeMetaTransaction is just a wrapper around runMetaTransaction, with the only difference being that it doesn't return the ProcedureOutput, but only the procedure's Err.

You are right, the main reason to use runMetaTransaction is so that we can collect the events that are included in the resulting ProcedureOutput. These events are accumulated throughout the bootstrapping process of the VM bridge, and at last they are included in the bootstrapExecutor's ProcedureOutput, which previously was simply an empty object .

The only other issue I had to fix, was setting a proper transaction index, for each transaction that was executed as part of the VM bridge bootstrap, as the order to EVM.TransactionExecuted events is critical for the EVM Gateway.

Other than that, I didn't notice any side effects.

[Kay-Zee]

Alright, LGTM!

[janezpodhostnik]

Nice!
Only had one minor comment.

[m-Peter]

Nice! Only had one minor comment.

@janezpodhostnik There doesn't seem to be any written comments 😅

[janezpodhostnik]

if we don't need run anymore can we rename runAndReturn to run

[m-Peter]

Good point 👍 Renamed it in 46df27c .

[janezpodhostnik]

Sorry about that. Added it now.