[Storage] Refactor index execution result #8005
Draft
+1,245
−711
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhangchiqing
changed the title
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
zhangchiqing
commented
Oct 8, 2025
| rootCmd.AddCommand(leaders.Cmd) | ||
| rootCmd.AddCommand(epochs.RootCmd) | ||
| rootCmd.AddCommand(edbs.RootCmd) | ||
| rootCmd.AddCommand(index_er.RootCmd) |
There was a problem hiding this comment.
This tool is no longer useful since this PR. Because now we don't allow multiple results to be stored for the same block, therefore we don't have multiple results to choose from which one to be reindexed with.
zhangchiqing
commented
Oct 8, 2025
| ctx.Throw(fmt.Errorf("could not acquire lock for collection indexing: %w", err)) | ||
| return | ||
| } | ||
| defer lctx.Release() |
There was a problem hiding this comment.
Mistake like this will happen, in order to avoid this, I will create a separate PR to replace all AcquireLock usages with storage.WithLock
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work towards #7912
This PR refactors execution result related storage operations to add lock ctx