[Pebble] Update pebble to 2.1 #8009
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterargue
commented
Oct 3, 2025
| MaxConcurrentCompactions: func() int { return 4 }, | ||
| Logger: util.NewLogger(logger), | ||
| // The default is 1, 1. | ||
| CompactionConcurrencyRange: func() (upper int, lower int) { return 1, 4 }, |
There was a problem hiding this comment.
made into a range: cockroachdb/pebble#4635
should this be 4, 4?
peterargue
commented
Oct 3, 2025
| l.TargetFileSize = opts.Levels[i-1].TargetFileSize * 2 | ||
| } | ||
| l.EnsureDefaults() | ||
| l.EnsureL0Defaults() |
There was a problem hiding this comment.
peterargue
commented
Oct 3, 2025
Comment on lines
-49
to
-52
| if i > 0 { | ||
| // L0 starts at 2MiB, each level is 2x the previous. | ||
| l.TargetFileSize = opts.Levels[i-1].TargetFileSize * 2 | ||
| } |
There was a problem hiding this comment.
option moved, but default matches our config anyway so I removed it:
https://github.com/RaduBerinde/pebble/blob/e0404d4b319d21f7d340bc27173e18020af04ada/options.go#L876-L877
peterargue
commented
Oct 3, 2025
| // Splitting sstables during flush allows increased compaction flexibility and concurrency when those | ||
| // tables are compacted to lower levels. | ||
| opts.FlushSplitBytes = opts.Levels[0].TargetFileSize | ||
| opts.FlushSplitBytes = opts.TargetFileSizes[0] |
There was a problem hiding this comment.
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
|
this needs #8008 |
zhangchiqing
approved these changes
Oct 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update pebble to the latest. This will be needed to update
ipfs/go-ds-pebbleto pull in the changes from the mainline repo for #8007