-
Notifications
You must be signed in to change notification settings - Fork 3
Switch to @onkernel/cu-playwright package and template refactoring #39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
- Remove templates/typescript/computer-use directory and all related files - Update CLI to make computer-use template Python-only - Remove TypeScript-specific computer-use examples from invoke samples - Simplify template offerings while preserving Python computer-use functionality - TypeScript users can use the cua template for computer use functionality
I think we still want to include a cu sample app in
|
Yep working on the cu sample here #42 should we put that in this pr too? I thought seperating will be cleaner |
β¦terface and linting setup
- Rename templates/python/computer-use -> templates/python/claude-cu - Rename templates/typescript/anthropic-computer-use -> templates/typescript/claude-cu - Update index.ts to use 'claude-cu' template name for both Python and TypeScript - Update app names: python-cu -> python-claude-cu, ts-anthropic-cu -> ts-claude-cu - Update README.md with new template names and examples - Maintain git history with git mv for clean diffs
@juecd made the changes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What Changed
This PR overhauls the computer-use templates. The key change is the removal of the custom implementation in templates/typescript/computer-use
and its replacement with a new, simpler template that leverages the @onkernel/cu-playwright
package. For consistency, both the Python and TypeScript templates have been renamed to claude-cu
, providing a unified name for users of create-kernel-app
. The new TypeScript template also introduces modern tooling like ESLint and Prettier, improving code quality.
Risks / Concerns
This is a fantastic refactor that simplifies the codebase by abstracting complex logic into the @onkernel/cu-playwright
package. The changes are well-structured and significantly improve the developer experience by unifying the template names. The only minor point of feedback was a suggestion to fully delete a _gitignore
file instead of leaving it empty in a removed template directory, which is a trivial cleanup. No significant risks were identified.
25 files reviewed | 1 comments | Review on Mesa | Edit Reviewer Settings
@@ -1,39 +0,0 @@ | |||
# Dependencies |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this entire template directory is being removed in favor of the new claude-cu
template, this file should probably be deleted entirely rather than just emptied. An empty gitignore file in a deprecated template directory doesn't serve any purpose.
Type: Logic | Severity: Low
Description
π Implementation Changes
π¦ Template Restructuring
Updated app names for consistency:
Python: python-cu β python-claude-cu
TypeScript: ts-anthropic-cu β ts-claude-cu
Implementation Checklist
Everything below is not applicable
Testing
Docs
Visual Proof
3. *Sucessful run of a query *
Related Issue
maybe related?
Additional Notes
git mv
to preserve file history during template renames for python