Skip to content

Conversation

@errt
Copy link
Collaborator

@errt errt commented Oct 21, 2025

Minor code improvements, mostly from IDE suggestions

@errt errt added this to the Release 7.0.0 milestone Oct 21, 2025
@errt errt requested a review from johannesduesing October 21, 2025 17:12
Dominik Helm added 2 commits October 24, 2025 19:07
@errt errt force-pushed the feature/assorted-improvements branch from 7aadbcb to b36623b Compare November 4, 2025 14:08
@errt errt marked this pull request as ready for review November 4, 2025 14:14
Copy link
Collaborator

@johannesduesing johannesduesing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the latest test fix, this looks good to me 👍
I did have a look into the errors during documentation generation, specifically could not resolve a member for the given link query - it seems that this can be fixed by using fully qualified names when referencing classes in ScalaDoc comments, i.e., chaning the following

/**
 * A scheduler for the reachable method [[SystemPropertiesAnalysis]] that is triggered on the [[Callers]] property.

to

/**
 * A scheduler for the reachable method [[org.opalj.tac.fpcf.analyses.systemproperties.SystemPropertiesAnalysis]] that is triggered on the [[org.opalj.br.fpcf.properties.cg.Callers]] property.

Fixed two of those errors. In total it should account for many of the 314 documentation warnings, but certainly not all of them. I don't know if you want to make that part of this PR or not, just thought i would mention it.

@errt
Copy link
Collaborator Author

errt commented Nov 5, 2025

I thought we tried this before with no success, but it seems to be the correct answer. I wouldn't include it in this PR, but we can certainly try it in another one. Although I'm not too happy that this will create very long links kind of unnecessarily.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants