Skip to content

bump SUNDIALS submodule to v6.7.0 (blocked by CAMP not supporting SUNDIALS >= 6) #343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

bump SUNDIALS submodule to v6.7.0 (blocked by CAMP not supporting SUNDIALS >= 6) #343

wants to merge 3 commits into from

Conversation

slayoo
Copy link
Member

@slayoo slayoo commented Feb 27, 2024

No description provided.

@slayoo slayoo changed the title bump SUNDIALS submodule to v6.7.0 bump SUNDIALS submodule to v6.7.0 (blocked by CAMP not supporting SUNDIALS >= 6) Feb 27, 2024
@slayoo
Copy link
Member Author

slayoo commented Feb 27, 2024

this fails with:

      /home/runner/work/PyPartMC/PyPartMC/gitmodules/camp/src/camp_solver.c:145:11: error: too few arguments to function ‘N_VNew_Serial’
        145 |   sd->y = N_VNew_Serial(n_dep_var * n_cells);
            |           ^~~~~~~~~~~~~

We need to update SUNDIALS calls within CAMP as it was done by @alhirzel for PartMC in compdyn/partmc@db9d8dc

@slayoo slayoo mentioned this pull request Apr 2, 2024
Closed
@github-actions GitHub Actions
Copy link

Stale pull request message

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@slayoo