Skip to content

fix(model): resolve update-called-attribute issue #2862 #2873

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix(model): resolve update-called-attribute issue #2862 #2873

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f4917c0
fix - update-called-attribute
harsh1504660 Aug 6, 2025
6fcf4c2
Modified the post processor for new _update_called method
harsh1504660 Aug 7, 2025
6528aa2
Merge branch 'main' into fix/update-called-attribute
harsh1504660 Aug 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/anomalib/post_processing/post_processor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,15 +135,15 @@ def on_validation_epoch_end(self, trainer: Trainer, pl_module: LightningModule)
del trainer, pl_module
if self.enable_thresholding:
# compute threshold values
if self._image_threshold_metric.update_called:
if getattr(self._image_threshold_metric, "_update_called", False):
Copy link
Contributor

@ashwinvaidya17 ashwinvaidya17 Aug 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am personally not in favour of using getattrs if possible. If the image threshold metric isn't set, it will be None. In that case we can just compare it against null value.

self._image_threshold.copy_(self._image_threshold_metric.compute())
self._image_threshold_metric.reset()
if self._pixel_threshold_metric.update_called:
self._pixel_threshold.copy_(self._pixel_threshold_metric.compute())
self._pixel_threshold_metric.reset()
if self.enable_normalization:
# compute normalization values
if self._image_min_max_metric.update_called:
if getattr(self._image_min_max_metric, "_update_called", False):
image_min, image_max = self._image_min_max_metric.compute()
self.image_min.copy_(image_min)
self.image_max.copy_(image_max)
Expand Down
Loading