Skip to content

Conversation

@Rickypanta0
Copy link

📝 Description

This PR addresses issue #2959 by upgrading the project's minimum Python version from Python 3.10 to Python 3.13. It addresses dependency constraints, updates CI configurations, and applies necessary fixes to code and tests to ensure compatibility with the updated environment.

Key Changes & Rationale:

  1. CI/CD Upgrade: Updated GitHub Actions (pre_merge.yml) and documentation to use Python 3.13.
  2. Dependency Resolution:
    • Updated pyproject.toml and uv.lock to support Python 3.13.
    • Restricted cu118 and cu121 extras to python_version < '3.13', as PyTorch does not provide wheels for these CUDA versions on Python 3.13 (which defaults to CUDA 12.4).
  3. ONNX Export Fix:
    • Switched torch.onnx.export to use the legacy JIT exporter (dynamo=False) in export_mixin.py.
    • Reason: The new Dynamo exporter enforces stricter graph tracing and currently fails with GuardOnDataDependentSymNode due to data-dependent control flow in post_processor.py (specifically isnan() checks). The legacy exporter handles this correctly.
  4. Test Adjustments:
    • Relaxed tolerance in test_inference_similarity (from 1e-3 to 3-e3).
    • Reason: Minor floating-point precision differences were observed between Torch and OpenVINO inference with the updated library versions.

✨ Changes

Select what type of change your PR is:

  • 🚀 New feature (non-breaking change which adds functionality)
  • 🐞 Bug fix (non-breaking change which fixes an issue)
  • 🔄 Refactor (non-breaking change which refactors the code base)
  • ⚡ Performance improvements
  • 🎨 Style changes (code style/formatting)
  • 🧪 Tests (adding/modifying tests)
  • 📚 Documentation update
  • 📦 Build system changes
  • 🚧 CI/CD configuration
  • 🔧 Chore (general maintenance)
  • 🔒 Security update
  • 💥 Breaking change (fix or feature that would cause existing functionality to not work as expected)

✅ Checklist

Before you submit your pull request, please make sure you have completed the following steps:

  • 📚 I have made the necessary updates to the documentation (if applicable).
  • 🧪 I have written tests that support my changes and prove that my fix is effective or my feature works (if applicable).
  • 🏷️ My PR title follows conventional commit format.

@Rickypanta0 Rickypanta0 force-pushed the chore/ci/upgrade-python-3-13 branch from 87bbf95 to aee7d36 Compare November 13, 2025 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

🔼 Upgrade the minimum python requirement to 3.13

1 participant