Skip to content

Conversation

@camiloHimura
Copy link

📝 Description

This PR updates the media item container to let users disable the current project and enable the selected one. It also shows informative messages when a project has no sources or sinks, or when inference isn’t available.

Note: The next PR will update the workflow to enable the WebRTC stream without requiring a trained model.

Screen.Recording.2025-11-14.at.14.06.12.mov
  • Provide a clear summary of the changes and the issue that has been addressed.
  • 🛠️ Fixes # (issue number)

✨ Changes

Select what type of change your PR is:

  • 🚀 New feature (non-breaking change which adds functionality)
  • 🐞 Bug fix (non-breaking change which fixes an issue)
  • 🔄 Refactor (non-breaking change which refactors the code base)
  • ⚡ Performance improvements
  • 🎨 Style changes (code style/formatting)
  • 🧪 Tests (adding/modifying tests)
  • 📚 Documentation update
  • 📦 Build system changes
  • 🚧 CI/CD configuration
  • 🔧 Chore (general maintenance)
  • 🔒 Security update
  • 💥 Breaking change (fix or feature that would cause existing functionality to not work as expected)

✅ Checklist

Before you submit your pull request, please make sure you have completed the following steps:

  • 📚 I have made the necessary updates to the documentation (if applicable).
  • 🧪 I have written tests that support my changes and prove that my fix is effective or my feature works (if applicable).
  • 🏷️ My PR title follows conventional commit format.

For more information about code review checklists, see the Code Review Checklist.

Copilot AI review requested due to automatic review settings November 14, 2025 13:16
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enables users to switch between active projects in the inspection workflow. When a project is inactive, users see an informative message with an option to activate it, which will disable the currently active project. The UI also displays helpful messages when projects lack required configurations (sources/sinks) or trained models.

Key changes:

  • Added project enable/disable functionality with confirmation dialogs
  • Refactored media actions to show contextual messages based on project state
  • Enhanced project list to highlight the active project and stop WebRTC when switching

Reviewed Changes

Copilot reviewed 24 out of 25 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
application/ui/src/routes/welcome.tsx Updated welcome message branding
application/ui/src/routes/inspect/inspect.tsx Replaced InferenceResult with MediaActions component
application/ui/src/hooks/use-pipeline.hook.ts Added active pipeline query and cache invalidation
application/ui/src/hooks/index.ts Exported pipeline hooks
application/ui/src/features/inspect/toolbar/toolbar.tsx Extracted ModelsPicker to separate file
application/ui/src/features/inspect/toolbar/models-picker.component.tsx New component for model selection
application/ui/src/features/inspect/stream/stream-container.tsx Refactored container structure and styling
application/ui/src/features/inspect/stream/stream-container.module.scss New styles for stream container
application/ui/src/features/inspect/projects-management/projects-list.component.tsx Added active project tracking
application/ui/src/features/inspect/projects-management/project-list-item/project-list-item.test.tsx Added navigation test
application/ui/src/features/inspect/projects-management/project-list-item/project-list-item.module.scss Added active state styling
application/ui/src/features/inspect/projects-management/project-list-item/project-list-item.component.tsx Added WebRTC stop and active state handling
application/ui/src/features/inspect/media-actions/train-model-message/* New message component for missing models
application/ui/src/features/inspect/media-actions/source-sink-message/* New message component for missing configuration
application/ui/src/features/inspect/media-actions/media-actions.component.tsx New orchestrator for media action states
application/ui/src/features/inspect/media-actions/inference-result/* Refactored inference result component
application/ui/src/features/inspect/media-actions/enable-project/* New components for project activation flow
application/ui/src/features/inspect/inference-result.component.tsx Removed (moved to media-actions)
application/ui/src/assets/icons/index.ts Exported new LinkExpired icon

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@camiloHimura camiloHimura force-pushed the ccolora11/disable-project-p2 branch from af29bf5 to b703792 Compare November 14, 2025 13:55
Signed-off-by: Colorado, Camilo <[email protected]>
Signed-off-by: Colorado, Camilo <[email protected]>
Signed-off-by: Colorado, Camilo <[email protected]>
Signed-off-by: Colorado, Camilo <[email protected]>
Copilot AI review requested due to automatic review settings November 14, 2025 16:24
@camiloHimura camiloHimura force-pushed the ccolora11/disable-project-p2 branch from b703792 to d8f95d5 Compare November 14, 2025 16:24
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 24 out of 25 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants