-
Notifications
You must be signed in to change notification settings - Fork 5
Fix/biomass adjustments #236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…d biogas potentials
tgilon
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @lisazeyen for these improvements! Only a few lines bringing a better approximation for NT.
I'm unable to reproduce your potential values. Let's have a quick chat about it.
Could you also add a visual overview of the changes in the PR description if you have it? And don't forget to add a release note, too.
daniel-rdt
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @lisazeyen! The improvement looks great. In addition to @tgilon's comments, I have just a few of my own that could improve the implementation a bit further.
tgilon
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I only have a few formatting comments left. Looks ready to go soon!
|
@tgilon thanks for the review! I addressed all your comments and added a plot for the new biomass/biogas potentials. Concerning the BtL as described in the PR: we will not exactly match the assumptions of TYNDP. This could be due to different efficiency assumptions, as well as that the full biomass potential is used for BtL, while in TYNDP parts of it are used for electricity production as well. |
tgilon
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One final issue, then good to go!
Co-authored-by: Daniel Rüdt <[email protected]>
Co-authored-by: Thomas Gilon <[email protected]>
for more information, see https://pre-commit.ci
|
@lisazeyen Anything else to add before merging the PR? |
No, this one is ready to go. |
Closes # (if applicable).
Changes proposed in this Pull Request
This PR:
Biomass potentials before and after PR
BtL
Our efficiency for BtL is 0.3833. This results in a bioliquid production in EU27 of 1263 x 0.3833=434 TWh (2030) and 1363TWh x 0.3833=522 TWh (2040)
Tasks
Workflow
Open issues
We are not matching the biofuel assumptions in TYNDP since
Notes
Checklist
pixi.toml(usingpixi add <dependency-name>).config/config.default.yaml.doc/configtables/*.csv.config/test/*.yaml.doc/data_sources.rst.doc/*.rstfiles.doc/release_notes.rstis added.READMEanddoc/index.rst.