chore: add multi-module compatible Makefile targets - #684
Open
sahidvelji wants to merge 5 commits into
Open
Conversation
github-actions
Bot
assigned
c4milo,
gagantrivedi,
kinyoklion,
matthewelwell and
thomaspoignant
github-actions
Bot
requested review from
c4milo,
gagantrivedi,
kinyoklion,
matthewelwell and
thomaspoignant
May 31, 2025 01:32
sahidvelji
marked this pull request as draft
May 31, 2025 01:32
sahidvelji
marked this pull request as ready for review
May 31, 2025 01:35
Signed-off-by: Sahid Velji <sahidvelji@gmail.com>
aepfli
reviewed
Jun 2, 2025
aepfli
approved these changes
Jun 5, 2025
beeme1mr
approved these changes
Jun 10, 2025
erka
approved these changes
Jun 10, 2025
github-actions
Bot
requested review from
Kavindu-Dodan,
bacherfl,
c4milo,
gagantrivedi,
kinyoklion and
matthewelwell
June 11, 2025 01:46
Signed-off-by: Sahid Velji <sahidvelji@gmail.com>
sahidvelji
removed request for
Kavindu-Dodan,
bacherfl,
c4milo,
gagantrivedi,
kinyoklion,
matthewelwell and
thomaspoignant
June 11, 2025 01:51
github-actions
Bot
requested review from
Kavindu-Dodan,
bacherfl,
c4milo,
gagantrivedi,
kinyoklion,
matthewelwell and
thomaspoignant
June 12, 2025 21:26
Signed-off-by: Simon Schrottner <simon.schrottner@dynatrace.com>
Member
|
I fixed the merge conflicts - i am really struggeling in my prs with linting etc. so is there anything i can help you with to move forward, and to get linting running again? |
Contributor
Author
thomaspoignant
approved these changes
Aug 26, 2025
Member
|
@sahidvelji could you please update this PR so we could merge it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
12 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR
Add Makefile targets mostly copied from https://github.com/open-telemetry/opentelemetry-go-contrib/blob/bridges/otelslog/v0.10.0/Makefile
Note that the lint stage fails, but that will be fixed in a separate follow-up PR.
Related Issues
Fixes #683
Notes
In order to keep my PRs small and manageable, I not did commit the results of running these new Makefile targets, especially because there is some additional work required in order for them to work. For example, some tests are failing and some linter findings need manual intervention.
Follow-up Tasks
How to test