feat(ofrep): http handler implementation - #736
Open
ZackarySantana wants to merge 3 commits into
Open
Conversation
Member
|
Hey @ZackarySantana I am not sure to understand what is the goal of this HTTP Handler. GO has already an OFREP provider https://github.com/open-feature/go-sdk-contrib/tree/main/providers/ofrep, and I am not sure to understand what this is bringing around OFREP. |
Author
|
Hey @thomaspoignant, this adds a server-side http handler wrapper so a go provider can be exposed over OFREP and then accessed by other clients. For example a provider written in go can be exposed with this handler and then consumed from the javascript ofrep provider (or another go ofrep provider, in a microservice architecture). |
Author
|
I expose it as a handler and leave serving it to the consumer, so they can add authentication and etc. |
Signed-off-by: Zackary Santana <64446617+ZackarySantana@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR
After starting to adopt an ofrep client, I was surprised there's no minimal http handler wrapper around a go openfeature provider already. This PR adds a very bare bone one. This is my first time contributing to this repo, so feel free to critique it!
How to test