feat: allowing null/missing default values #1511
Merged
+10
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rahul Baradol <[email protected]>
github-actions
bot
requested review from
beeme1mr,
Kavindu-Dodan,
thisthat and
toddbaert
guidobrei
reviewed
Jul 14, 2025
There was a problem hiding this comment.
Thanks for the contribution, @Rahul-Baradol.
I've added some comments on things that cached my attention.
Wondreing what the Gherkin tests will reveal.
...rc/main/java/dev/openfeature/contrib/providers/flagd/resolver/process/InProcessResolver.java
Outdated
Show resolved
Hide resolved
...rc/main/java/dev/openfeature/contrib/providers/flagd/resolver/process/InProcessResolver.java
Outdated
Show resolved
Hide resolved
...rc/main/java/dev/openfeature/contrib/providers/flagd/resolver/process/InProcessResolver.java
Outdated
Show resolved
Hide resolved
|
@Rahul-Baradol if it's any help, here is my JS implementation of the same thing. I'm happy to add the e2e tests here once your implementation is complete, so you can ignore that part. |
beeme1mr
changed the title
|
FYI, I've updated the title to remove the |
Signed-off-by: Simon Schrottner <[email protected]>
Signed-off-by: Simon Schrottner <[email protected]>
|
@Rahul-Baradol i hope you dont mind me fixing your conflict, and activating our e2e test suite for your feature. Now this code runs against the e2e tests which we are also using in other languages. |
|
Sure, I don't have issues ! |
aepfli
reviewed
Jul 24, 2025
...rc/main/java/dev/openfeature/contrib/providers/flagd/resolver/process/InProcessResolver.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Rahul Baradol <[email protected]>
aepfli
approved these changes
Jul 28, 2025
guidobrei
approved these changes
Jul 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
FLAG_NOT_FOUND,Related Issues
Fixes #1438