feat: add mechanism for open-close-principle to OpenFeatureApi #1015
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
first we check an env var, if this is not set, we use a property file else we fallback furthermore we fallback to the default if the provided class name can not be initialized Signed-off-by: Simon Schrottner <[email protected]>
aepfli
force-pushed
the
proposal/open-close-principal
branch
from
5b28fd3 to
0ffb228
Compare
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1015 +/- ##
============================================
- Coverage 95.04% 93.83% -1.21%
- Complexity 392 393 +1
============================================
Files 38 38
Lines 888 909 +21
Branches 54 58 +4
============================================
+ Hits 844 853 +9
- Misses 24 33 +9
- Partials 20 23 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
after a night of sleep, i still think this is a feasible idea, but it will not help me in my endavours. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this approach we allow people to modify the OpenFeatureApi Singleton.
The user can either provide an environment variable called
OPEN_FEATURE_API_CLASSor a property file calledopenfeature.propertieswith which they can control the class, which will be used for instantiation.first the environmental variable
second the properties file
third the default
(optional we could add system properties)
The provided class needs to extend OpenFeatureApi, and if we're not able to instantiate this class, we will fall to the default
This is just a proposal, of how we could add the open-close principle to the OpenFeatureApi, this approach could also work in other languages like python or c# - not sure of the others.