chore: improvements to release workflow

[toddbaert]

A few improvements to our release workflow:

• splits release into 2 jobs, this is nice because we can re-run the actual maven publish independently if it fails due to an issue with OSSRH
• skips tests on maven publish (no point in testing again when we are publishing)

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.31%. Comparing base (d9a72d2) to head (de9cc04).
Report is 1 commits behind head on main.

Additional details and impacted files

@@             Coverage Diff              @@
##               main    #1451      +/-   ##
============================================
+ Coverage     92.88%   93.31%   +0.42%     
- Complexity      483      485       +2     
============================================
  Files            45       45              
  Lines          1167     1167              
  Branches        101      101              
============================================
+ Hits           1084     1089       +5     
+ Misses           53       48       -5     
  Partials         30       30              

Flag	Coverage Δ
unittests	93.31% <ø> (+0.42%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[beeme1mr]

• splits release into 2 jobs, this is nice because we can re-run the actual maven publish independently if it fails due to an issue with OSSRH

Unfortunately, I don't think this change will help. You'll be able to rerun the workflow but it won't attempt to republish.

[beeme1mr]

You shouldn't need the fromJSON workaround here since you're already handling it on line 28. I suppose it doesn't hurt to be extra careful though.

[toddbaert]

Ya, we've keep it like this in most places.

[toddbaert]

• splits release into 2 jobs, this is nice because we can re-run the actual maven publish independently if it fails due to an issue with OSSRH

Unfortunately, I don't think this change will help. You'll be able to rerun the workflow but it won't attempt to republish.

That doesn't seem to be what the doc says:

If any jobs in a workflow run failed, you can re-run just the jobs that failed. When you re-run failed jobs in a workflow, a new workflow run will start for all failed jobs and their dependents. Any outputs for any successful jobs in the previous workflow run will be used for the re-run. Any artifacts that were created in the initial run will be available in the re-run. Any deployment protection rules that passed in the previous run will automatically pass in the re-run.

https://docs.github.com/en/actions/managing-workflow-runs-and-deployments/managing-workflow-runs/re-running-workflows-and-jobs#re-running-failed-jobs-in-a-workflow

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud