Skip to content

feat: Allow Access to ImmutableMetadata Map as unmodifiable Map #1534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

carla-was-not-available
Copy link
Contributor

Oriented on the AbstractStructure
closes: #1532

Oriented on the AbstractStructure
closes: open-feature#1532

Signed-off-by: Carla Köberl <[email protected]>
@carla-was-not-available carla-was-not-available requested review from a team as code owners July 30, 2025 19:06
Signed-off-by: Carla Köberl <[email protected]>
Copy link

codecov bot commented Jul 30, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.24%. Comparing base (477d7ce) to head (f0e6873).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1534      +/-   ##
============================================
+ Coverage     92.81%   93.24%   +0.43%     
- Complexity      486      489       +3     
============================================
  Files            46       46              
  Lines          1169     1170       +1     
  Branches        103      103              
============================================
+ Hits           1085     1091       +6     
+ Misses           54       49       -5     
  Partials         30       30              
Flag Coverage Δ
unittests 93.24% <100.00%> (+0.43%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@toddbaert toddbaert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @carla-was-not-available !

This is satisfactory, IMO, though I must say I hate the state of our "POJO/DTO" classes, in terms of how inconsistent they are. I would love to extract an interface or two for all these sorts of methods and make sure all such objects adhere to it, removing other cruft, though that's probably going to require a v2.

Copy link

@aepfli aepfli merged commit 09e3c3f into open-feature:main Jul 31, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No access to ImmutableMetadata keys
4 participants