Skip to content

chore: add assertion for hook context contents #977

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 23, 2024
Merged

chore: add assertion for hook context contents #977

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 31 additions & 2 deletions packages/server/test/client.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ import {
EvaluationContext,
EvaluationDetails,
FlagNotFoundError,
Hook,
JsonArray,
JsonObject,
JsonValue,
Expand All @@ -18,6 +19,8 @@ import {
TransactionContextPropagator,
} from '../src';
import { OpenFeatureClient } from '../src/client/internal/open-feature-client';
import { isDeepStrictEqual } from 'node:util';
import { HookContext } from '@openfeature/core';

const BOOLEAN_VALUE = true;
const STRING_VALUE = 'val';
Expand Down Expand Up @@ -740,9 +743,35 @@ describe('OpenFeatureClient', () => {
// Set Client Context
const client = OpenFeature.getClient('contextual', 'test', clientContext);
// Set Hook Context
client.addHooks({ before: () => beforeHookContext });
const hook = {
before: jest.fn((hookContext: HookContext) => {
// we have to put this assertion here because of limitations in jest with expect.objectContaining and mutability
if (isDeepStrictEqual(hookContext.context, {
...globalContext,
...transactionContext,
...clientContext,
...invocationContext,
// before hook context should be missing here (and not overridden)
})) {
return beforeHookContext;
}
}),
after: jest.fn((hookContext: HookContext) => {
// we have to put this assertion here because of limitations in jest with expect.objectContaining and mutability
if (isDeepStrictEqual(hookContext.context, {
...globalContext,
...transactionContext,
...clientContext,
...invocationContext,
...beforeHookContext,
})) {
return beforeHookContext;
}
}),
} as unknown as Hook;

await client.getBooleanValue(flagKey, defaultValue, invocationContext, { hooks: [hook] });

await client.getBooleanValue(flagKey, defaultValue, invocationContext);
expect(provider.resolveBooleanEvaluation).toHaveBeenCalledWith(
expect.anything(),
expect.anything(),
Expand Down
Loading