Skip to content

Commit a120d8a

Browse files
authored
test: fix flaky test (#130)
Signed-off-by: Nicklas Lundin <[email protected]>
1 parent af07e0f commit a120d8a

File tree

2 files changed

+7
-32
lines changed

2 files changed

+7
-32
lines changed

android/src/test/java/dev/openfeature/sdk/DeveloperExperienceTests.kt

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -258,11 +258,9 @@ class DeveloperExperienceTests {
258258
waitAssert {
259259
assertEquals(OpenFeatureStatus.NotReady, OpenFeatureAPI.getStatus())
260260
}
261-
testScheduler.advanceTimeBy(1)
262261
waitAssert {
263-
assertEquals(OpenFeatureStatus.NotReady, OpenFeatureAPI.getStatus())
262+
assertTrue(OpenFeatureAPI.getStatus() is OpenFeatureStatus.Error)
264263
}
265-
testScheduler.advanceTimeBy(healDelayMillis)
266264
waitAssert {
267265
assertEquals(OpenFeatureStatus.Ready, OpenFeatureAPI.getStatus())
268266
}

android/src/test/java/dev/openfeature/sdk/StatusTests.kt

Lines changed: 6 additions & 29 deletions
Original file line numberDiff line numberDiff line change
@@ -55,46 +55,23 @@ class StatusTests {
5555

5656
@Test
5757
fun testProviderTransitionsToReconcilingOnContextSet() = runTest {
58-
assertEquals(OpenFeatureStatus.NotReady, OpenFeatureAPI.getStatus())
58+
waitAssert {
59+
assertEquals(OpenFeatureStatus.NotReady, OpenFeatureAPI.getStatus())
60+
}
5961
val statuses = mutableListOf<OpenFeatureStatus>()
6062
val job = launch {
6163
OpenFeatureAPI.statusFlow.collect {
6264
statuses.add(it)
6365
}
6466
}
6567
OpenFeatureAPI.setProviderAndWait(DoSomethingProvider())
66-
testScheduler.advanceUntilIdle()
68+
waitAssert { assertEquals(OpenFeatureStatus.Ready, OpenFeatureAPI.getStatus()) }
6769
OpenFeatureAPI.setEvaluationContextAndWait(ImmutableContext("some value"))
68-
testScheduler.advanceUntilIdle()
69-
waitAssert {
70-
assertEquals(4, statuses.size)
71-
}
72-
73-
OpenFeatureAPI.setEvaluationContextAndWait(ImmutableContext("some other value"))
74-
testScheduler.advanceUntilIdle()
70+
waitAssert { assertEquals(OpenFeatureStatus.Reconciling, OpenFeatureAPI.getStatus()) }
7571
waitAssert {
76-
assertEquals(6, statuses.size)
77-
}
78-
79-
OpenFeatureAPI.shutdown()
80-
testScheduler.advanceUntilIdle()
81-
waitAssert {
82-
assertEquals(OpenFeatureStatus.NotReady, OpenFeatureAPI.getStatus())
72+
assertEquals(OpenFeatureStatus.Ready, OpenFeatureAPI.getStatus())
8373
}
8474
job.cancelAndJoin()
85-
86-
assertEquals(
87-
listOf(
88-
OpenFeatureStatus.NotReady,
89-
OpenFeatureStatus.Ready,
90-
OpenFeatureStatus.Reconciling,
91-
OpenFeatureStatus.Ready,
92-
OpenFeatureStatus.Reconciling,
93-
OpenFeatureStatus.Ready,
94-
OpenFeatureStatus.NotReady
95-
),
96-
statuses
97-
)
9875
}
9976
}
10077

0 commit comments

Comments
 (0)