fix(flagd): handle falsy target values correctly #214
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: AdityaVallabh <[email protected]>
AdityaVallabh
force-pushed
the
adi-falsy
branch
from
875c1b9 to
7e7fef2
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #214 +/- ##
==========================================
+ Coverage 93.89% 94.00% +0.10%
==========================================
Files 18 18
Lines 950 950
==========================================
+ Hits 892 893 +1
+ Misses 58 57 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
aepfli
reviewed
Mar 16, 2025
There was a problem hiding this comment.
thank you for your great contribution. This solves your issue as described, but i am not sure, we want to continue in the future with exceptions anyways for handling our flow. Hence i wrote a little comment, and hope some of the Python-masters can help and guide us.
...rs/openfeature-provider-flagd/src/openfeature/contrib/provider/flagd/resolvers/in_process.py
Show resolved
Hide resolved
Signed-off-by: AdityaVallabh <[email protected]>
Signed-off-by: AdityaVallabh <[email protected]>
AdityaVallabh
force-pushed
the
adi-falsy
branch
from
1ee3395 to
df130a6
Compare
aepfli
approved these changes
Mar 17, 2025
gruebel
approved these changes
Mar 18, 2025
Signed-off-by: AdityaVallabh <[email protected]>
AdityaVallabh
force-pushed
the
adi-falsy
branch
from
5f34f07 to
e7ad1f6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
Prevents erroneous exception when dealing with falsy values.
Related Issues
Fixes #213
Notes
N/A
Follow-up Tasks
N/A
How to test
Added a bunch of UTs.