feat(flagd): use json schema validation instead of custom validation #282
+32
−82
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #282 +/- ##
==========================================
- Coverage 94.21% 90.47% -3.74%
==========================================
Files 20 5 -15
Lines 1020 189 -831
==========================================
- Hits 961 171 -790
+ Misses 59 18 -41 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
aepfli
force-pushed
the
feat/add-jsonschema-validator
branch
14 times, most recently
from
c618aaf to
c6211d0
Compare
Signed-off-by: Simon Schrottner <[email protected]>
aepfli
force-pushed
the
feat/add-jsonschema-validator
branch
from
c6211d0 to
049424a
Compare
chrfwow
approved these changes
Jul 17, 2025
Signed-off-by: Simon Schrottner <[email protected]>
|
Basically it is a good change, but i see a lot of problems currently, with inconsistencies with other languages - and i think we should refine this a little bit better, before merging this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changed the code to rely on json schema instead of custom validation, should be more error proof for the future