Skip to content

Conversation

ChiragAgg5k
Copy link
Member

@ChiragAgg5k ChiragAgg5k commented Sep 7, 2025

wraps runner class with a Executor class to handle createExecution

allows us to override the executor resource to better handle how createExecution should work for static vs ssr images

@ChiragAgg5k ChiragAgg5k requested a review from Copilot September 7, 2025 12:07
Copilot

This comment was marked as outdated.

@ChiragAgg5k ChiragAgg5k requested a review from Copilot September 7, 2025 12:17
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors the execution handling system to use a new Executor class instead of directly using the Runner class. The change introduces a cleaner abstraction layer while maintaining the same underlying Docker runner functionality.

Key changes:

  • Introduces a new Executor class that extends the existing Docker Runner
  • Updates dependency injection to use Executor instead of Runner in controllers
  • Maintains backward compatibility by keeping the existing Runner instance available

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
src/Executor/Executor.php Creates new Executor class that extends Docker Runner
app/http.php Adds Executor instantiation and resource registration alongside existing Runner
app/controllers.php Updates controller to inject and use Executor instead of Runner

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@ChiragAgg5k ChiragAgg5k marked this pull request as draft September 8, 2025 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants