Instrumentation api change - option 2#1540
Draft
LikeTheSalad wants to merge 3 commits intoopen-telemetry:mainfrom
Draft
Instrumentation api change - option 2#1540LikeTheSalad wants to merge 3 commits intoopen-telemetry:mainfrom
LikeTheSalad wants to merge 3 commits intoopen-telemetry:mainfrom
Conversation
LikeTheSalad
force-pushed
the
inst-api-change-option2
branch
from
4434e68 to
8e2b406
Compare
Member
fractalwrench
left a comment
fractalwrench
left a comment
There was a problem hiding this comment.
This comment on #1539 applies to this PR too: https://github.com/open-telemetry/opentelemetry-android/pull/1539/changes#r2730782298
Basically: does it make sense to expose this functionality for only the log record signals, or consider exposing a way to orderly shutdown the SDK as a whole?
I'd also suggest that we don't necessarily need to expose this as part of the public API, with a few internal changes. OpenTelemetryRum could set its own UncaughtExceptionHandler separate from the crash instrumentation and shutdown signal collection in an orderly manner, without needing to provide a public API.
This was referenced Jan 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DO NOT MERGE
This is a proposal for this issue: #1541 - It's meant to highlight the key changes, without addressing potential compilation errors, if any. If chosen as the approach we'd like to go with, then I'll add the rest of the changes needed for the build to pass.