Add the MQ metrics shaded jar to the release artifacts#2682
Merged
breedx-splk merged 1 commit intoopen-telemetry:mainfrom Mar 13, 2026
Merged
Add the MQ metrics shaded jar to the release artifacts#2682breedx-splk merged 1 commit intoopen-telemetry:mainfrom
breedx-splk merged 1 commit intoopen-telemetry:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the GitHub release workflow to include the IBM MQ metrics shaded JAR as part of the release artifacts, aligning it with the existing JMX metrics/scraper release attachments.
Changes:
- Download the
opentelemetry-ibm-mq-metricsshaded (-all) jar and its.ascsignature from Maven Central when running inalready-publishedmode. - Copy the IBM MQ shaded jar/signature into simplified top-level filenames for release attachment.
- Include the IBM MQ shaded jar in provenance attestation and the
gh release createasset list.
Comment on lines
+121
to
+124
| curl -L -o ibm-mq-metrics/build/libs/opentelemetry-ibm-mq-metrics-$VERSION-alpha-all.jar \ | ||
| "https://repo1.maven.org/maven2/io/opentelemetry/contrib/opentelemetry-ibm-mq-metrics/$VERSION-alpha/opentelemetry-ibm-mq-metrics-$VERSION-alpha-all.jar" | ||
| curl -L -o ibm-mq-metrics/build/libs/opentelemetry-ibm-mq-metrics-$VERSION-alpha-all.jar.asc \ | ||
| "https://repo1.maven.org/maven2/io/opentelemetry/contrib/opentelemetry-ibm-mq-metrics/$VERSION-alpha/opentelemetry-ibm-mq-metrics-$VERSION-alpha-all.jar.asc" |
There was a problem hiding this comment.
The new curl downloads for the IBM MQ shaded JAR don’t use --fail (or equivalent). If Maven Central returns a 404/5xx HTML response, curl can still exit successfully and you’ll end up attaching an invalid file to the GitHub release. Consider adding --fail --show-error (and optionally retries) to these downloads (and ideally keep the behavior consistent with the other artifact downloads in this step).
breedx-splk
approved these changes
Mar 13, 2026
Contributor
breedx-splk
left a comment
breedx-splk
left a comment
There was a problem hiding this comment.
Looks good to me. 👍🏻
Merged
via the queue into
open-telemetry:main
with commit Mar 13, 2026
370bd65
37 of 40 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Add a jar to the release items.