Skip to content

Conversation

@rockbmb
Copy link
Collaborator

@rockbmb rockbmb commented Oct 21, 2025

Closes #432 , closes #451, closes #449.

To be merged only after the Polkadot Asset Hub Migration finishes on both Polkadot relay and AH.
It is scheduled for November 4th.

Vesting periods now elapse according to a non-local block provider,
the relay's, as opposed to a local one; vesting E2E tests and snapshots
required an update that was not done for KAHM as vesting was mistakenly
filtered there (even after the migration).
@rockbmb rockbmb added this to the Polkadot Migration milestone Oct 21, 2025
@rockbmb rockbmb self-assigned this Oct 21, 2025
@rockbmb rockbmb added e2e tests Related to end-to-end tests snapshots Issue concerning stale, redundant or incorrect snapshots. labels Oct 21, 2025
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes introduce a hardcoded magic number '8' in vesting calculations within the shared package, which could lead to issues on other chains. The reason for this number is not sufficiently explained in the code.

@rockbmb
Copy link
Collaborator Author

rockbmb commented Oct 22, 2025

Will also close #451 .

@rockbmb rockbmb changed the title Updates to E2E for Polkadot AHM Update PET to integrate Polkadot AHM changes Oct 23, 2025
@rockbmb
Copy link
Collaborator Author

rockbmb commented Nov 2, 2025

Will also close #449 (takes Kusama tests from #462 and adjusts for Polkadot).

@rockbmb rockbmb marked this pull request as ready for review November 2, 2025 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

e2e tests Related to end-to-end tests snapshots Issue concerning stale, redundant or incorrect snapshots.

Projects

None yet

2 participants