breakdown known good block numbers #460
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
The script for updating environment variables has an inconsistency. When updating known-good block numbers for CI, it uses a fallback if a network call fails. However, when updating the local .env file, this fallback logic has been removed, which could lead to missing block numbers during local development if a network call fails. All other changes look good.
| } catch (error: any) { | ||
| console.error(`Failed to fetch block number for ${name}: ${error.message}`) | ||
| return null | ||
| } |
There was a problem hiding this comment.
The fallback logic for when a block number cannot be fetched has been removed for the local development case (when isUpdateKnownGood is false). The previous implementation would use the existing value from the .env file, but the new code returns null, causing the variable to be omitted. This is inconsistent with the behavior for the isUpdateKnownGood case, which retains the fallback logic (lines 63-70). Please restore the fallback behavior for the local development environment to prevent accidentally losing block numbers if a network request fails.
closes #459