Repository navigation
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Maven coordinates conflict with #1676, and the proposed old-coordinate relocation artifacts are missing.
2 open findings
What changed in this PR
Rebrands the SDK from Serverless Workflow to Open Workflow across Java packages, Maven coordinates, SPI registrations, tests, examples, and documentation.
Changes:
- Migrates Java namespaces from
io.serverlessworkflowtoorg.openworkflow. - Renames Maven artifacts and service-provider descriptors.
- Updates branding and supporting test resources.
| File | Description |
|---|---|
types/.../Errors.java, Defaults.java |
Migrates type packages and branding. |
serialization/.../SerializeHelper.java |
Migrates serialization package/imports. |
mermaid/src/main/**, mermaid/src/test/** |
Migrates Mermaid implementation and tests. |
impl/**/META-INF/services/** |
Migrates SPI descriptor names and providers. |
impl/test/** |
Migrates test packages, proto namespace, and fixtures. |
impl/persistence/** |
Migrates persistence APIs, tests, and documentation. |
impl/openapi/**, impl/openapi-jackson/** |
Migrates OpenAPI packages and providers. |
impl/model/** |
Migrates model implementation and marshalling providers. |
impl/json-utils/** |
Migrates Jackson utilities and tests. |
impl/core/** |
Migrates core APIs, implementations, lifecycle types, and tests. |
impl/http/**, impl/grpc/**, impl/function/** |
Migrates executor modules and providers. |
impl/jwt-impl/**, impl/jq/**, impl/javascript/** |
Migrates optional runtime integrations. |
impl/cron/**, impl/template/**, impl/validation/** |
Migrates supporting service modules. |
impl/a2a/**, impl/container/**, impl/python/** |
Migrates additional executor integrations. |
generators/** |
Migrates generator packages. |
fluent/spec/** |
Migrates fluent API builders, SPI, and configurers. |
fluent/pom.xml, annotations/pom.xml |
Renames Maven coordinates and artifacts. |
examples/** |
Migrates example imports and packages. |
api/** |
Migrates public API and serialization packages. |
annotations/** |
Migrates annotation packages. |
.github/ISSUE_TEMPLATE/** |
Updates issue-template branding. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
…to org.openworkflow Signed-off-by: Francisco Javier Tirado Sarti <ftirados@ibm.com>
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Some Maven artifacts, runtime messages, and documentation still reference the old branding and coordinates.
12 open findings
2 resolved since last review
🧠 Review effort: Balanced
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Two Maven generator references retain obsolete artifact IDs, preventing the types and api modules from resolving their build-time generators.
6 open findings
8 resolved since last review
🧠 Review effort: Balanced
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Several changed public APIs still expose the former branding and repository location in generated documentation.
8 open findings
2 resolved since last review
🧠 Review effort: Balanced
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
A runtime error URI and published BOM description still expose the legacy branding.
6 open findings
🧠 Review effort: Balanced
Collaborator
Author
Yes, I forgot we already discussed that, updating. |
fjtirado
requested review from
ricardozanini
and
a balanced review from Copilot
October 9, 2026 16:20
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Several launch configurations, native-image reflection entries, and documentation examples reference nonexistent packages or coordinates.
13 open findings
1 resolved since last review
🧠 Review effort: Balanced
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
The repository-wide breaking rename spans public APIs, generated sources, persistence compatibility, and runtime SPI discovery across many modules.
9 open findings
4 resolved since last review
🧠 Review effort: Balanced
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
The repository-wide breaking namespace and coordinate migration requires final human validation of publishing and compatibility behavior.
2 open findings
7 resolved since last review
🧠 Review effort: Balanced
Signed-off-by: Francisco Javier Tirado Sarti <ftirados@ibm.com>
Collaborator
|
@fjtirado let's keep the event types names to not break the API see: open-workflow-specification/specification#1189 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #1676
We rename to org.openworkflow.sdk both for package name and groupid (discarding cloud.openworkflow)