Skip to content
This repository was archived by the owner on Mar 21, 2025. It is now read-only.

Fixes Incomplete URL substring sanitization vulnerability detected by CodeQL - #3521

Open
Onyx2406 wants to merge 1 commit into
openMF:developfrom
Onyx2406:Incomplete_URL_substring_sanitization
Open

Fixes Incomplete URL substring sanitization vulnerability detected by CodeQL#3521
Onyx2406 wants to merge 1 commit into
openMF:developfrom
Onyx2406:Incomplete_URL_substring_sanitization

Conversation

@Onyx2406

Copy link
Copy Markdown

Description

The fix parse a URL before performing a check on its host value, and ensure that the check handles arbitrary subdomain sequences correctly.

  • The statement hostname === 'mifos.io' will check if the hostname is exactly 'mifos.io'.
  • The statement domains.slice(-2).join('.') === 'mifos.io' will check if the last two parts of the hostname (split by '.') are 'mifos.io'.
  • Also, the updated code doesn't use indexOf anymore and therefore is not vulnerable to URL spoofing attacks that were possible with the original code.
  • It uses the endsWith method to check if the hostname ends with 'mifos.io'.

Related issues and discussion

#3520

Screenshots, if any

image

Checklist

Please make sure these boxes are checked before submitting your pull request - thanks!

  • [] Validate the JS and HTML files with grunt validate to detect errors and potential problems in JavaScript code.
    giving network error "grunt validate" giving network error #3519

  • [] Run the tests by opening test/SpecRunner.html in the browser to make sure you didn't break anything.

  • If you have multiple commits please combine them into one commit by squashing them.

  • Read and understood the contribution guidelines at community-app/Contributing.md.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant