-
Notifications
You must be signed in to change notification settings - Fork 5.6k
Feat/nix on droid #4959
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Feat/nix on droid #4959
Conversation
I have read the CLA Document and I hereby sign the CLA mike seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
cp -r $src/* . | ||
cp ${root-pnpm-lock} pnpm-lock.yaml | ||
export PNPM_HOME=$(pwd)/.pnpm-store | ||
pnpm install --ignore-scripts --store-dir $PNPM_HOME |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Package codex-cli without vendored binary
The install phase installs dependencies with pnpm install --ignore-scripts
and only copies bin/codex.js
into $out/bin
. The CLI immediately tries to spawn vendor/<target>/codex
(see bin/codex.js
), but no vendor directory is produced or installed here—--ignore-scripts
prevents any postinstall steps that might fetch the binary, and nothing builds or bundles codex-rs
. Running nix build
or nix run
for this package will therefore fail at runtime with ENOENT
because the expected native binary is missing. The derivation should build or link the codex binary into the output instead of packaging just the wrapper script.
Useful? React with 👍 / 👎.
There are some issues I am working on, this is not building just yet. |
nix on droid.
This is using my fork of nixpkgs but otherwise should be good for everyone on nix on droid.
Still work in progress, but builds.