Add confirmation prompt for enabling full access approvals #4980
+233
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dylan-hurd-oai
commented
Oct 9, 2025
| pub windows_wsl_setup_acknowledged: bool, | ||
|
|
||
| /// Tracks whether the user has acknowledged the full access warning prompt. | ||
| pub full_access_warning_acknowledged: bool, |
There was a problem hiding this comment.
cc @jif-oai for config thoughts - should we nest this under some kind of global_user_store field?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds a confirmation screen when a user attempts to select Full Access via the
/approvalsflow in the TUI.If the user selects the remember option, the preference is persisted to config.toml as
full_access_warning_acknowledged, so they will not be prompted again.Testing
https://chatgpt.com/codex/tasks/task_i_68e6c5c458088322a28efa3207058180