Skip to content

docs: demonstrate server-owned tool approval state - #1951

Merged
seratch merged 1 commit into
mainfrom
docs/server-owned-approval-state
Sep 20, 2026
Merged

seratch merged 1 commit into
mainfrom
docs/server-owned-approval-state

Conversation

@seratch

@seratch seratch commented Sep 20, 2026

Copy link
Copy Markdown
Member

This pull request updates the human-in-the-loop guide to clarify that deserializing RunState does not authenticate the snapshot or authorize the reviewer.
It adds a CLI client/server simulation that keeps snapshots on the server, checks ownership, validates boolean decisions against stored identifiers, and consumes each approval request before resuming execution. Regression tests cover unauthorized submissions, mutation, concurrent requests, replay, failure, and cancellation.
The guide explains production requirements for authentication, atomic shared storage, sensitive display data, and recovery after uncertain tool side effects. SDK APIs and serialization remain unchanged.

@seratch
seratch requested a review from a team as a code owner September 20, 2026 21:57
@seratch seratch added the documentation Improvements or additions to documentation label Sep 20, 2026
@changeset-bot

changeset-bot Bot commented Sep 20, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 1a0dbb0

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 20, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-20T21:59:32.576761Z 1a0dbb0 PR opened
🔒 Security Review ✅ Completed 2026-09-20T21:59:54.843279Z 1a0dbb0 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@markstuart-oai markstuart-oai left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the complete diff at 1a0dbb0. The shared server example keeps snapshots private, binds decisions to stored interruptions and the authenticated owner, validates a complete boolean batch, and consumes the request before awaited restoration or execution. The tests cover tampering, mixed decisions, repeated pauses and replay across concurrent submission, failure and cancellation. The guide accurately separates this single-process demonstration from production authentication, shared storage and recovery. No actionable correctness or structural findings.

Exact-head hosted CI has 16 successful checks and one skipped deployment, including passing Node 22/24.3 tests, coverage, build and Windows checks. Source review only; I did not run local tests, a live model or a deployed approval service.

@seratch
seratch merged commit 9121190 into main Sep 20, 2026
17 checks passed
@seratch
seratch deleted the docs/server-owned-approval-state branch September 20, 2026 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation project

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants